[FLINK-39171][oracle-cdc] Fix Oracle pipeline connector wrong field case#4292
Merged
lvyanquan merged 2 commits intoapache:masterfrom Mar 25, 2026
Merged
Conversation
| org.apache.flink.cdc.common.schema.Column cdcColumn = | ||
| org.apache.flink.cdc.common.schema.Column.physicalColumn( | ||
| column.name().toLowerCase(Locale.ROOT), dataType); | ||
| column.name(), dataType); |
Contributor
There was a problem hiding this comment.
Removing the lowercase conversion may introduce an incompatibility. Should this be controlled by a configuration option for backward compatibility?
Member
Author
There was a problem hiding this comment.
The oracle pipeline connector not release yet. So I think this is not a big deal. :)
c8e444b
Hisoka-X
changed the title
lvyanquan
reviewed
Mar 24, 2026
...tor-oracle/src/main/java/org/apache/flink/cdc/connectors/oracle/utils/OracleSchemaUtils.java
Outdated
Show resolved
Hide resolved
…Oracle column name handling Extract the removeQuotes method to OracleSchemaUtils to centralize Oracle table/column name case handling logic. This method follows Oracle naming rules: names enclosed in double quotes retain their original case, otherwise they are converted to uppercase. This change improves code reuse between OracleSchemaUtils and BaseParserListener, making it easier to add configuration options for case handling in the future. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Thanks @lvyanquan and @ruanhang1993! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close https://issues.apache.org/jira/browse/FLINK-39171
This pull request standardizes the handling of Oracle table and column names by preserving their original case throughout the schema extraction, test event creation, and test assertions. Previously, names were converted to lowercase, which could cause mismatches and confusion when working with case-sensitive database objects. Now, table and column names are kept in their original case, improving consistency and correctness across the codebase and tests.